Release 2022.3.7 · EntelectChallenge/2022-Arctica

TianCilliers · August 19, 2022, 10:37pm

Seems like 2022.3.6 fixes my crash in TerritoryService, but hangs infinitely at the start due waiting for bots to join (configured for one bot) due to the if (!bot.Territory.Contains(building.Position)) return; check. Is this known?

EDIT: nope still crashes, only did at ~1500 instead of tick ~900 like normal

kobus-v-schoor · August 20, 2022, 8:32am

@Jordan @Jenique Ran into smallish bug, it looks like some units can get stuck at resource nodes when the node is almost full. It looks like it’s affecting multiple resources and I’ve seen it occurring in multiple games. I think the issues lies here:

github.com

EntelectChallenge/2022-Arctica/blob/da519fb7ba4888fbe9b58f7f83746f6622697b5a/game-engine/Engine/Services/EngineService.cs#L255-L271

      
        
            foreach (var action in actions)
            {
                var newUnits = (int) Math.Floor(action.NumberOfUnits * distributionFactor);
                if (newUnits == 0)
                {
                    Logger.LogInfo("ResourceNode Slot Distribution", $"Not enough space at node id {node.Id}, removing action for bot id {action.Bot.BotId}");
                    action.Remove();
                }
                else
                {
                    SendUnneededUnitsHome(action, newUnits); 
                    action.NumberOfUnits = newUnits;
                }
            
            
}
            var adjustedTotalUnits = actions.Sum(action => action.NumberOfUnits);
            node.CurrentUnits += adjustedTotalUnits;

If the newly calculated action units is zero, the action is removed from the bot (with the action.Remove() call), but the action.NumberOfUnits is left intact and still gets added to the node since the action isn’t removed from the actions list. Since the action is removed from the bot it doesn’t get processed later on in the tick simulation:

github.com

EntelectChallenge/2022-Arctica/blob/da519fb7ba4888fbe9b58f7f83746f6622697b5a/game-engine/Engine/Services/EngineService.cs#L366-L380

      
        
            public void SimulateTickForBots(IList<BotObject> bots)
            {
                var actionsToComplete = new List<PlayerAction>();
                foreach (var bot in bots)
                {
                    var currentActions = bot.GetActions();
            
            
        foreach (var playerAction in currentActions)
                    {
                        if (playerAction.IsComplete(worldStateService.GetCurrentTick()))
                        {
                            actionsToComplete.Add(playerAction);
                        }
                    }
                }

I’m guessing at this point those units become stuck as the action is lost to the void of the garbage collector.

PS: Haven’t ran into the other crash again