Possible bug in order of moves

justin.worthe · August 10, 2019, 2:27pm

Hi team!

In the rules, it says that the commands are processed in the following order:

1. Select
2. Movement
3. Digging
4. Banana
5. Snowball
6. Shooting

It looks to me like this is implemented by having an int called order on each command and sorting by it. However, it looks like Banana and Snowball both have the same ordering value (3).

Banana: 2019-Worms/game-engine/src/commonMain/kotlin/za/co/entelect/challenge/game/engine/command/implementation/BananaCommand.kt at develop · EntelectChallenge/2019-Worms · GitHub
Snowball: 2019-Worms/game-engine/src/commonMain/kotlin/za/co/entelect/challenge/game/engine/command/implementation/SnowballCommand.kt at develop · EntelectChallenge/2019-Worms · GitHub

The impact of this bug would be that it isn’t clearly defined what order those two commands are processed in. Sometimes you can freeze an opponent worm before they banana bomb you, sometimes you can’t.

Thanks!

pierre.roux · August 11, 2019, 12:56pm

Hi @justin.worthe

Great catch .Snowballs should only block worms from being issued new commands. Commands issued before they were frozen, should still be executed as long as they were not frozen when those commands were issued.

The code responsible for this is here:

github.com

EntelectChallenge/2019-Worms/blob/develop/game-engine/src/commonMain/kotlin/za/co/entelect/challenge/game/engine/command/CommandExecutor.kt

package za.co.entelect.challenge.game.engine.command

import mu.KotlinLogging
import za.co.entelect.challenge.game.engine.command.feedback.CommandFeedback
import za.co.entelect.challenge.game.engine.command.feedback.StandardCommandFeedback
import za.co.entelect.challenge.game.engine.config.GameConfig
import za.co.entelect.challenge.game.engine.map.WormsMap
import za.co.entelect.challenge.game.engine.player.WormsPlayer
import za.co.entelect.challenge.game.engine.processor.GameError
import za.co.entelect.challenge.game.engine.renderer.printables.VisualizerEvent

class CommandExecutor(private val player: WormsPlayer,
                      private val map: WormsMap,
                      private val command: WormsCommand,
                      private val config: GameConfig) {

    val worm = player.currentWorm
    // Moves are validated on command executor construction
    private val moveValidation = command.validate(map, worm)

This file has been truncated. show original

A quick look shows that frozen worms will miss out on their shoot commands. We will investigate this, I believe Snowballs need to be moved to have the last rank in the command ordering ranks.

justin.worthe · August 11, 2019, 4:19pm

Thanks @pierre.roux! I didn’t realize that being able to stop worms from shooting by freezing them was unintentional. I agree that reordering it such that the snowballs are the last command should fix this.

japes · August 11, 2019, 4:57pm

Hi @pierre.roux,

Probably related to this:

It looks like if 2 worms try to snowball each other in the same turn, player 1’s will take effect first, preventing player 2 from throwing his.

Probably not what was intended? I have a match log showing this, if you’d like.

pierre.roux · August 11, 2019, 7:48pm

That seems like the bug that would happen in the current release. The intended effect should be that the snowballs have both been thrown, before the first one hits a worm…this way both should get frozen.

We will fix this in the upcoming release with the final balance tweaks soon